D1564: worker: make windows workers daemons

wlis (Wojciech Lis) phabricator at mercurial-scm.org
Mon Dec 18 14:04:44 EST 2017


wlis added inline comments.

INLINE COMMENTS

> worker.py:285
> +                threads.remove(t)
> +    except Exception: # re-raises
> +        trykillworkers()

I forgot to update this diff with KeyboardInterrupt again which doesn't derive from Exception, but BaseException instead. I will try to get the 1 line patch up asap.
Currently the ctrl-c wouldn't be handled gracefully on windows

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1564

To: wlis, #hg-reviewers, ikostia, durin42
Cc: durin42, durham, ikostia, mercurial-devel


More information about the Mercurial-devel mailing list