D1719: debug: remove an 'if ui.debug()' that is not doing anything

spectral (Kyle Lippincott) phabricator at mercurial-scm.org
Mon Dec 18 23:00:51 EST 2017


spectral added a comment.


  In https://phab.mercurial-scm.org/D1719#29390, @quark wrote:
  
  > I think it should be `ui.debugflag`.
  
  
  I agree that's probably what was intended, but is it helpful to have it if it's never once been activated in 5 years?  (added: https://phab.mercurial-scm.org/rHG4bec77e62c00b45912c41e5e76bfc994d6692133, 2012-12-13).  (Ironically, if I ever actually ran this command I'd probably want it to have the behavior I'm deleting, but considering no one else has wanted it enough to fix the issue here, it feels too much like dead code/YAGNI for my tastes)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1719

To: spectral, #hg-reviewers
Cc: quark, mercurial-devel


More information about the Mercurial-devel mailing list