D1736: osutil: add a function to unblock signals

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Wed Dec 20 08:25:41 EST 2017


yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> osutil.c:1123
> +	sigemptyset(&set);
> +	sigaddset(&set, sig);
> +	r = sigprocmask(SIG_UNBLOCK, &set, NULL);

Nit: `sigaddset()` may raise EINVAL if the given signum is invalid.
Maybe it's also better to check the result of `sigemptyset()` for clarity.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1736

To: quark, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list