D1747: repoview: add visibilityexception argument to filterrevs() and related fns

[yuja (Yuya Nishihara)]

yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> repoview.py:157
>          func = filtertable[filtername]
> -        repo.filteredrevcache[filtername] = func(repo.unfiltered())
> +        repo.filteredrevcache[filtername] = func(repo.unfiltered(),
> +                                                 visibilityexceptions)

Since revisions are dynamically unhidden, we can't cache the result
to the (unfiltered) repo per `filterename`.

Perhaps we could apply `visibilityexceptions` at repoview.changelog().

  revs = filterrevs(unfi, self.filtername)
  revs = revs - self._visibilityexceptions

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1747

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel