D1732: revsetlang: add utility function to return hash like symbols from the tree

[yuja (Yuya Nishihara)]

yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> revsetlang.py:665
> +
> +_hashre = util.re.compile('[0-9a-fA-F]{1,40}')
> +

Oops, one more thing. Needs `$` to match whole word.

Test something like `('symbol', 'abe3ffZ')`.

> revsetlang.py:691
> +            results += gethashlikesymbols(subtree)
> +        # return directly, we don't need to filter symbols again
> +        return results

Nit: this comment should be removed.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1732

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel