D1733: scmutil: add utility fn to return repo object with user passed revs unhidden

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Tue Dec 26 08:51:29 EST 2017


yuja added inline comments.

INLINE COMMENTS

> scmutil.py:1322
> +
> +    if not repo.filtername.startswith('visible'):
> +        return repo

It seems better to use an explicit list of filternames,
i.e. `('visible', 'visible-hidden')`. I don't think we should introduce
new naming scheme, 'visible<x>'.

Can you send a followup?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1733

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list