D1735: commands: use the new API to access hidden changesets in various commands

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Tue Dec 26 08:55:12 EST 2017


yuja added inline comments.

INLINE COMMENTS

> yuja wrote in commands.py:1283
> Maybe needs `if rev:`?
> Passing revspec=[''] seems not right.

Can you send a followup?

Passing `['']` works because `parse('')` raises ParseError, but
that doesn't seem legit.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1735

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list