D1753: streamclone: preserve remote phases (issue5648)

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Wed Dec 27 13:34:20 EST 2017


indygreg added inline comments.

INLINE COMMENTS

> yuja wrote in streamclone.py:191
> Shouldn't we test `remotephases.get('publishing', False)` for
> mixed-phase + publishing server?

Maybe.

My reasoning here was that if the remote advertises phases data, then it is phases aware and the code below will ensure phases are adjusted appropriately. We certainly could special case the mixed phase + publishing case and skip all phase adjustment.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1753

To: indygreg, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list