D1773: revlog: use named attributes on revlog index entries
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Thu Dec 28 13:56:41 EST 2017
indygreg added a comment.
In https://phab.mercurial-scm.org/D1773#30283, @yuja wrote:
> Not reviewed the series yet, but can't we just start with a custom type
> backed by C so we don't have to import back IndexV1Entry from Python?
That's possible. I do have a work-in-progress patch to the C code to implement such a type.
However, it is quite large and I suspect it will take a bit more effort to finish it. The end result of this series gets us into a state where the C type can be swapped in with minimal effort. I have a soft preference for implementing the type in C as a follow-up. But I can refactor the series if wanted. Or someone can review this series without accepting it and I'll add the C type later.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1773
To: indygreg, #hg-reviewers
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list