[PATCH] graphlog: add another graph node type, unstable, signified by character "*"

Augie Fackler raf at durin42.com
Thu Dec 28 15:27:57 EST 2017


On Thu, Dec 28, 2017 at 10:08:21PM +0900, Yuya Nishihara wrote:
> On Fri, 22 Dec 2017 23:59:34 +0800, Anton Shestakov wrote:
> > # HG changeset patch
> > # User Anton Shestakov <av6 at dwimlabs.net>
> > # Date 1513955824 -28800
> > #      Fri Dec 22 23:17:04 2017 +0800
> > # Node ID 9a1654009818562a26e99c535df7de532780ce75
> > # Parent  bb6a80fc969a2c5da80cbb7f29de7ca576c4e251
> > graphlog: add another graph node type, unstable, signified by character "*"
>
> "(BC)" could be added in flight.

Will do. Queued.

>
> > diff --git a/mercurial/templatekw.py b/mercurial/templatekw.py
> > --- a/mercurial/templatekw.py
> > +++ b/mercurial/templatekw.py
> > @@ -538,6 +538,8 @@ def showgraphnode(repo, ctx, **args):
> >          return '@'
> >      elif ctx.obsolete():
> >          return 'x'
> > +    elif ctx.isunstable():
> > +        return '*'
> >      elif ctx.closesbranch():
> >          return '_'
> >      else:
> > diff --git a/tests/test-amend.t b/tests/test-amend.t
> > --- a/tests/test-amend.t
> > +++ b/tests/test-amend.t
> > @@ -188,7 +188,7 @@ With allowunstable, amend could work in
> >    $ hg log -T '{rev} {node|short} {desc}\n' -G
> >    @  3 be169c7e8dbe B
> >    |
> > -  | o  2 26805aba1e60 C
> > +  | *  2 26805aba1e60 C
> >    | |
> >    | x  1 112478962961 B
> >    |/
>
> I'm 0 on this, but I have no reason against it. Any comments?

That's my feeling too. I've gone ahead and taken it because it seems
like a reasonable thing overall.

> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list