[PATCH 1 of 2 remotenames-ext] lazyremotenamedict: make iteritems able to not check whether nodes exist

Sean Farley sean at farley.io
Fri Feb 3 22:23:45 UTC 2017


Kostia Balytskyi <ikostia at fb.com> writes:

> # HG changeset patch
> # User Kostia Balytskyi <ikostia at fb.com>
> # Date 1485451944 28800
> #      Thu Jan 26 09:32:24 2017 -0800
> # Node ID 904e442f868455ba9cb66347733804ff3a6d98e0
> # Parent  090d16362edd806ec4843c1f0b49d331bec6e524
> lazyremotenamedict: make iteritems able to not check whether nodes exist
>
> Similar to `keys()` method, we don't always want to resolve every node
> in the changelog, sometimes all we're interested in is the node hash.
>
> diff --git a/remotenames.py b/remotenames.py
> --- a/remotenames.py
> +++ b/remotenames.py
> @@ -367,6 +367,19 @@ class lazyremotenamedict(UserDict.DictMi
>              return self.cache.keys()
>          return self.potentialentries.keys()
>  
> +        """Iterate over (name, node) tuples

Is this a bad rebase? That return statement seems wrong now with the
code below.


More information about the Mercurial-devel mailing list