[PATCH 2 of 6 v2] util: add an elapsed time wrapper

Simon Farnsworth simonfar at fb.com
Fri Feb 3 17:55:01 EST 2017


On 03/02/2017 22:36, Bryan O'Sullivan wrote:
> On Fri, Feb 3, 2017 at 2:26 PM, Simon Farnsworth <simonfar at fb.com
> <mailto:simonfar at fb.com>> wrote:
>
>     Assuming the community doesn't object strongly, I'll redo to be
>     unconditionally measuring time (and only conditionally logging it),
>     as the overhead of conditionality seems excessive for this purpose.
>
>
> If you'd also use the same approach as I do of direct measurement in the
> places that actually do the I/O, instead of indirection, that would be
> great. In fact, I think you should take over my patches and adapt them
> to your needs. The added detail in my patches of measuring when
> Mercurial stops doing work, instead of when it exits, is going to be
> important to your purposes, because just counting ui I/O time won't
> capture that.
>

We already capture start and exit times in the external wrapper process 
- so your added detail of measuring "useful work" (in addition to "total 
time") tells us if we're seeing a huge overhead in setup/teardown of 
Mercurial.

-- 
Simon Farnsworth


More information about the Mercurial-devel mailing list