[PATCH] match: adding non-recursive directory matching

[Rodrigo Damazio]

Finally working on this again.
On point which I discussed with Martin offline - which feels more intuitive
as a prefix, "root" or "abs"? (so, "rootfilesin" or "absfilesin"?) We think
it's "abs", but wanted to make sure that's OK with others.

Thanks


On Sun, Jan 29, 2017 at 3:15 AM, FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
wrote:

>
> At Fri, 27 Jan 2017 15:14:38 -0800,
> Rodrigo Damazio wrote:
> >
> > [1  <multipart/alternative (7bit)>]
> > [1.1  <text/plain; UTF-8 (7bit)>]
> > On Fri, Jan 27, 2017 at 1:03 AM, FUJIWARA Katsunori <
> foozy at lares.dti.ne.jp>
> > wrote:
> >
> > >
> > > At Thu, 26 Jan 2017 17:27:17 -0800,
> > > Rodrigo Damazio wrote:
> > > >
> > > > [1  <multipart/alternative (7bit)>]
> > > > [1.1  <text/plain; UTF-8 (7bit)>]
> > > > All sounds very reasonable, and "filesin:" or "rootfilesin:" LGTM.
> > >
> > > Is it OK for your solution that "rootfilesin:FOO" doesn't match
> > > against "file FOO", even though your patch posted in this thread made
> > > "files:FOO" do so ? or, is combining "rootfile:" and "rootfilesin"
> > > acceptable for your solution ?
> > >
> >
> > Yes, not matching files is fine, and actually the easiest to implement
> (the
> > regex is simpler and our custom server doesn't support files anyway).
> > For that, rootfilesin:foo/bar can produce regex ^foo/bar/[^/]+$ or
> similar
> > which would not match a file called bar. visitdir would have to be
> updated
> > accordingly, of course, but that shouldn't be too hard (and i can take
> the
> > opportunity to add some comments to the code).
> >
> > If that looks good to you, let me know and I'll send an updated patch.
>
> Sure, LGTM
>
> --
> ----------------------------------------------------------------------
> [FUJIWARA Katsunori]                             foozy at lares.dti.ne.jp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170203/767f55db/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4847 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170203/767f55db/attachment.bin>