Gardening extensions

[Kevin Bullock]

> On Feb 6, 2017, at 14:44, Bryan O'Sullivan <bos at serpentine.com> wrote:
> 
> Not surprisingly, the pager extension isn't the only one in my sights at the moment.
> 
> Here are a few others I've been thinking about.
> 
> Proposals to move into core:
> 
> * color - approaching its tenth anniversary, and widely used.

+1

> * histedit - widely used for 5+ years.
> 
> * rebase - almost a decode old, widely used.

Both of these are still extensions because they enable history editing. I recall discussions around moving these into core being predicated on evolve going in first. But phases are already in core, which provide one safety baseline for history editing...? Then again, phases don't prevent you losing work from a botched rebase, they only prevent you duplicating public changes.

In principle, I'm +1 on moving them into core, but I'd like us to work out the safety implications for users in line with our established practice.

> Extensions to delete: for each of these, I propose adding a non-suppressible warning to stderr that it'll be deleted, keeping that around for one or two release cycles, then deleting the extension.

> 
> * children - almost 10 years old, obsoleted by the children() revset function years ago.

I'm not real enthused by the idea of a non-suppressible warning to stderr. I like our current approach of making the extension a dummy or shell around the newer core functionality. What's your reasoning for wanting a heavier-handed deprecation and removal cycle?

> * graphlog - its functionality has been in core hg for almost 5 years.

Same deal here, this is already a very simple wrapper around `hg log -G`.

> * record - obsoleted by crecord.

Err... to be more accurate, obsoleted by `hg commit -i`, which now also has a curses mode. But of course that's what you meant. ;)

> * transplant - sadly not entirely obsoleted by rebase, but kind of an obscenity anyway :-) (actually I just included this to see who reads this far)

It would be great to see `hg graft` grow the ability to graft from a remote repo. I believe that's the only reason transplant still exists.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock