[PATCH 1 of 6 v2] ui: provide a mechanism to track and log blocked time

Bryan O'Sullivan bos at serpentine.com
Thu Feb 9 19:44:33 EST 2017


On Thu, Feb 9, 2017 at 1:52 PM, Simon Farnsworth <simonfar at fb.com> wrote:

> ui: provide a mechanism to track and log blocked time
>

I looked through the whole series, and it generally looks good.

Could you please add a contrib/perf.py benchmark to measure the performance
of ui.write with this new context manager based scheme, and include the
results in the commit message?

I like your context manager approach for the infrequent-use cases, but for
high-frequency users (mainly just ui.write), I'm going to be unable to
shake a nagging worry that this is still "too much overhead" until I can be
reassured otherwise by actual numbers :-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170209/22921886/attachment.html>


More information about the Mercurial-devel mailing list