[PATCH 7 of 8 v4] extdiff: log time spent in external diff program

[Bryan O'Sullivan]

On Mon, Feb 13, 2017 at 10:25 AM, Simon Farnsworth <simonfar at fb.com> wrote:

> I want the caller to tell me what tag to apply to this blocking reason, so
> that I can account for the blocking in hook.py (where it's running a
> non-interactive process) and sshpeer.py (where it's network blocking as we
> talk to a server) differently to extdiff.py and filemerge.py (where it's an
> interactive process).
>
> I could push the instrumentation into ui.system, conditional on being
> passed a tag (with a catch-all for "not tagged") if people think that would
> be more useful?
>

I toyed with suggesting use of the first component of the string to be
executed by ui.system as the tag, but that's too trolly :-)

But yeah, passing in a tag and defaulting to something else (perhaps that
trolly suggestion?) sounds good.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170213/066f72cb/attachment.html>