[PATCH 4 of 5 v2] statprof: allow rendering in the Chrome trace viewer format

Bryan O'Sullivan bos at serpentine.com
Mon Feb 13 19:28:31 EST 2017


On Mon, Feb 13, 2017 at 3:13 PM, Augie Fackler <raf at durin42.com> wrote:

> My Rust brain was reading this code and was about to get puzzled that you
> didn't use an enum and have these just be
> fn write(&self, data, fp) -> Result<(), Error>. And then I got sad.
>

The code that makes you sad is a holdover from the times when statprof.py
was a standalone project. It contains a lot of stuff that I'd consider
unfortunate by modern Mercurial/Python standards :-)

I could probably do a little patch series to clean up statprof at some
point, but it feels non-urgent.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170213/54a8e10a/attachment.html>


More information about the Mercurial-devel mailing list