help: I broke test-gendoc-ro.t and I have no idea how

[Augie Fackler]

> On Feb 15, 2017, at 8:02 PM, Simon Farnsworth <simonfar at fb.com> wrote:
> 
> On 16/02/2017 00:21, Augie Fackler wrote:
>> With my pager-modernization work applied, I've got one test failure that is blocking me from mailing:
>> augie% make test-gendoc-ro.t
>> cd tests && python run-tests.py -j16 test-gendoc-ro.t
>> --- /usr/local/google/home/augie/Programming/hg/crew/tests/test-gendoc-ro.t
>> +++ /usr/local/google/home/augie/Programming/hg/crew/tests/test-gendoc-ro.t.err
>> @@ -2,3 +2,5 @@
>> 
>>   $ $TESTDIR/check-gendoc ro
>>   checking for parse errors
>> +  gendoc.txt:55: (WARNING/2) Inline interpreted text or phrase reference start-string without end-string.
>> +  gendoc.txt:55: (WARNING/2) Inline interpreted text or phrase reference start-string without end-string.
>> ERROR: test-gendoc-ro.t output changed
>> 
>> This is caused by something I did in https://urldefense.proofpoint.com/v2/url?u=https-3A__hg.durin42.com_hg-2Dwip_rev_b7285db7c604&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=mEgSWILcY4c4W3zjApBQLA&m=ChpAFOjlEYfm475yHPTI0tuFVtHpxkiVGexL5vsOh_I&s=-92RK09HMha8EYY79jfb7CRI0zekREVBhPPhmvIUYg0&e= , but I have no idea what. Can anyone help me figure out this last problem?
>> 
> 
> It looks to me like a consequence of moving pager into core, combined with a marginally iffy decision by the Romanian translator.
> 
> When pager is an extension, test-gendoc-ro.t will not test the Romanian translation of _("when to paginate (boolean, always, auto, or never)") - it's not in the source English text, so won't end up in the translated output.
> 
> You move _("when to paginate (boolean, always, auto, or never)") from pager.py to commands.py, which results in the source English text containing that phrase.
> 
> The Romanian translator has translated  _("when to paginate (boolean, always, auto, or never)") as "când să se pagineze (boolean, `always`=întotdeauna, auto, sau `never`=niciodată)". runrst then attempts to interpret `always`=întotdeauna and `never`=niciodată as references, and throws up this warning.
> 
> I can hunt round the office tomorrow for a friendly Romanian who can come up with a better way to indicate the relationship between the Romanian words and the English arguments - or you could decide to accept this warning for now until the Romanian translation is updated.

Neat. I’ll update the test for now with a note about what’s going on so I can mail this. Thanks!

> -- 
> Simon Farnsworth