[PATCH] run-tests: drop unused "useipv6" parameter from Test class

Martin von Zweigbergk martinvonz at google.com
Thu Feb 16 01:34:23 EST 2017


On Wed, Feb 15, 2017 at 10:28 PM, Jun Wu <quark at fb.com> wrote:
> Looks good to me. I was trying to make the test class "self-contained"
> without accessing global variables, as some people have strong opinion on
> global variables. So it was intentional. But removing the parameter leads to
> shorter code. I'm fine with either way.

Oh, I'm sorry. I didn't realize it was shadowing the global one. I'm
still not sure which I prefer, but since my patch wasn't just dropping
an unused parameter as I thought it did, let's just drop my patch.


More information about the Mercurial-devel mailing list