[PATCH] test-logtoprocess: fix the regular expression

Martin von Zweigbergk martinvonz at google.com
Thu Feb 16 13:29:39 EST 2017


On Thu, Feb 16, 2017 at 10:02 AM, Augie Fackler <raf at durin42.com> wrote:
>
>> On Feb 16, 2017, at 12:36, Jun Wu <quark at fb.com> wrote:
>>
>> Excerpts from Augie Fackler's message of 2017-02-16 12:18:56 -0500:
>>> On Thu, Feb 16, 2017 at 09:14:52AM -0800, Jun Wu wrote:
>>>> # HG changeset patch
>>>> # User Jun Wu <quark at fb.com>
>>>> # Date 1487265078 28800
>>>> #      Thu Feb 16 09:11:18 2017 -0800
>>>> # Node ID ea77104f008e26351dde0b168432b8d903c4f240
>>>> # Parent  677049d4e7cadc6acfc557ef1ee8acf783c76e1d
>>>> # Available At https://bitbucket.org/quark-zju/hg-draft
>>>> #              hg pull https://bitbucket.org/quark-zju/hg-draft  -r ea77104f008e
>>>> test-logtoprocess: fix the regular expression
>>>
>>> You still have two problems!
>>>
>>> (queued, many thanks for the fix)
>>
>> Actually this does not fix the problem as I thought. Please drop this :/

I think the problem is not with the regex, but with the test runner
and the async behavior of logtoprocess. logtoprocess.py says:

"Scripts are run asynchronously as detached daemon processes; mercurial will
not ensure that they exit cleanly."

I suspect that makes the test runner not match it with the regex.

>
> Dropped, make sure to `hg touch` it so you don't lose your copy.
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list