[PATCH 03 of 10 v5] ui: provide a mechanism to track and log blocked time

[Yuya Nishihara]

On Wed, 15 Feb 2017 14:06:53 -0800, Simon Farnsworth wrote:
> # HG changeset patch
> # User Simon Farnsworth <simonfar at fb.com>
> # Date 1487193465 28800
> #      Wed Feb 15 13:17:45 2017 -0800
> # Node ID f3a219226ba0658f72801329d07c1ba516152b70
> # Parent  1c71bddbe01e76c1c48b5479ff67d47645afd7b6
> ui: provide a mechanism to track and log blocked time

>      finally:
>          duration = util.timer() - starttime
>          req.ui.flush()
> +        if req.ui.logblockedtimes:
> +            req.ui._blockedtimes['command_duration'] = duration * 1000
> +            req.ui.log('uiblocked', 'ui blocked ms', **req.ui._blockedtimes)

[snip]

>              self._reportuntrusted = self.debugflag or self.configbool("ui",
>                  "report_untrusted", True)
>              self.tracebackflag = self.configbool('ui', 'traceback', False)
> +            self.logblockedtimes = self.configbool('ui', 'logblockedtimes')

Just curious. Why this config knob is needed only to suppress the output?
I thought this would stop tracking the blocked time at all.