[PATCH 8 of 9 pager v2] annotate: migrate to modern pager API

[Martin von Zweigbergk]

On Feb 18, 2017 03:18, "Yuya Nishihara" <yuya at tcha.org> wrote:

On Thu, 16 Feb 2017 11:59:17 -0500, Augie Fackler wrote:
> # HG changeset patch
> # User Augie Fackler <augie at google.com>
> # Date 1486439567 18000
> #      Mon Feb 06 22:52:47 2017 -0500
> # Node ID 4c2f3f1b67a71401faff082dbca79a3f212b5499
> # Parent  935dccd057eb61b980901b5c7a806fac9fb55d0f
> annotate: migrate to modern pager API
>
> diff --git a/hgext/pager.py b/hgext/pager.py
> --- a/hgext/pager.py
> +++ b/hgext/pager.py
> @@ -110,4 +110,4 @@ def uisetup(ui):
>          extensions.wrapfunction(dispatch, '_runcommand', pagecmd)
>      extensions.afterloaded('color', afterloaded)
>
> -attended = ['annotate', 'cat', 'diff', 'export', 'glog', 'log', 'qdiff']
> +attended = ['cat', 'diff', 'export', 'glog', 'log', 'qdiff']
> diff --git a/mercurial/commands.py b/mercurial/commands.py
> --- a/mercurial/commands.py
> +++ b/mercurial/commands.py
> @@ -361,6 +361,7 @@ def annotate(ui, repo, *pats, **opts):
>
>      Returns 0 on success.
>      """
> +    ui.pager('annotate')
>      if not pats:
>          raise error.Abort(_('at least one filename or pattern is
required'))

Just to make sure. Do we plan to delay ui.pager() call so short error
messages
(and password prompt, etc.) won't be paged?


I was wondering the same, but was hoping the pager would be configured to
exit if the full text would fit. I have no idea if that's true for most
systems out there, though. I don't believe I've manually configured mine
that way, so I suspect it's that way be default on our custom Ubuntu. I
guess pager on by default will be pretty annoying if that is not a common
default configuration, so I really hope it is.


_______________________________________________
Mercurial-devel mailing list
Mercurial-devel at mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170218/99fa0567/attachment.html>