[PATCH] patchbomb: allow specifying default --flag options via config(issue5354)

Yuya Nishihara yuya at tcha.org
Tue Feb 21 09:48:10 EST 2017


On Tue, 21 Feb 2017 08:55:07 +0530, Pulkit Goyal wrote:
> # HG changeset patch
> # User Pulkit Goyal <7895pulkit at gmail.com>
> # Date 1487593583 -19800
> #      Mon Feb 20 17:56:23 2017 +0530
> # Node ID 3c7e816697791c48de126c06c069af23c9e2bc3a
> # Parent  2c9e619ba9ee8e72370cc0f27f59da39947773b6
> patchbomb: allow specifying default --flag options via config(issue5354)
> 
> This patch adds support for specifying default flag to be added while sending
> patches using patchbomb per repsoitory. After this patch one can add flag to
> email section in hgrc like

I wanted to make it support templating so we can set 'flag = {topic}', etc.

https://www.mercurial-scm.org/pipermail/mercurial-devel/2015-April/068094.html

(Well, this wasn't an April Fool patch.)

Matt found this can be more generic, which seemed really nice, but no progress
since then, sigh. Maybe I should send V2 of this as I cannot design a nice
generic function right now.

> [email]
> to = mercurial-devel at mecurial-scm.org
> flag = evolve-ext

Perhaps "flag" should belong to the patchbomb section.

> @@ -202,9 +202,13 @@
>      else:
>          msg = mail.mimetextpatch(body, display=opts.get('test'))
>  
> +    fl = "flag"     # to avoid test-check-config.t from failing
> +    defaultflag = repo.ui.config('email', fl)

You need to document it to silence the checker.


More information about the Mercurial-devel mailing list