[PATCH] patchbomb: allow specifying default --flag options via config(issue5354)

Pulkit Goyal 7895pulkit at gmail.com
Tue Feb 21 15:58:55 EST 2017


>
> I wanted to make it support templating so we can set 'flag = {topic}', etc.
>
> https://www.mercurial-scm.org/pipermail/mercurial-devel/
> 2015-April/068094.html
>
> (Well, this wasn't an April Fool patch.)
>
> Matt found this can be more generic, which seemed really nice, but no
> progress
> since then, sigh. Maybe I should send V2 of this as I cannot design a nice
> generic function right now.
>

​I will be happy to make progress on that. The random emoji thing makes it
look like a April Fool patch, though it will be cool one to have ;).​

>
> > [email]
> > to = mercurial-devel at mecurial-scm.org
> > flag = evolve-ext
>
> Perhaps "flag" should belong to the patchbomb section.
>
> > @@ -202,9 +202,13 @@
> >      else:
> >          msg = mail.mimetextpatch(body, display=opts.get('test'))
> >
> > +    fl = "flag"     # to avoid test-check-config.t from failing
> > +    defaultflag = repo.ui.config('email', fl)
>
> You need to document it to silence the checker.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170222/2da2fea8/attachment.html>


More information about the Mercurial-devel mailing list