[PATCH 04 of 10] localrepo: move ui loading to baselocalrepository

Jun Wu quark at fb.com
Wed Feb 22 23:27:39 EST 2017


Excerpts from Kevin Bullock's message of 2017-02-22 20:31:14 -0600:
> There's another alternative we might consider: can we move all of the
> "side effects" out of the localrepository class entirely? That is, instead
> of resorting to inheritance, could we create a lower-level "repo storage"
> class that has enough logic to make vfs and svfs available, but doesn't
> call reposetup()?

That's what I'm doing - moving "extensions.loadall()" out from
localrepository.__init__, and together with chg refactoring,
extensions.extensions will eventually return a empty list so things could be
seen as side-effect free.


More information about the Mercurial-devel mailing list