[PATCH 13 of 13 V2] color: drop the 'colorui' class

Yuya Nishihara yuya at tcha.org
Sat Feb 25 00:23:45 EST 2017


On Fri, 24 Feb 2017 15:08:35 -0800, Durham Goode wrote:
> On 2/24/17 2:09 PM, Pierre-Yves David wrote:
> > # HG changeset patch
> > # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
> > # Date 1487590955 -3600
> > #      Mon Feb 20 12:42:35 2017 +0100
> > # Node ID 07fe8ac5a9038dece502507af9e59728a6a8c13a
> > # Parent  419d5f42cc7b764f5304b2518146824329c32f91
> > # EXP-Topic color
> > color: drop the 'colorui' class
> >
> > Now that all logics formally bared by 'colorui' have been moved to the main ui
> > class, that class is empty and can be dropped. As a nice side effect we can get
> > rid of the baroque Initialization associated to it.
> >
> > There was much rejoicing.
> 
> 
> This series looks good to me, from a correctness stand point.  There's a 
> few grammar spots, but not enough to require fixing I think.

Yeah, queued with some grammar fixes and trivial whitespace changes spotted by
flake8. Thanks!


More information about the Mercurial-devel mailing list