[PATCH 6 of 7] color: move triggering of the initialisation logic in core

Pierre-Yves David pierre-yves.david at ens-lyon.org
Mon Feb 27 09:52:43 EST 2017



On 02/27/2017 03:45 PM, Yuya Nishihara wrote:
> On Sat, 25 Feb 2017 14:11:38 +0100, Pierre-Yves David wrote:
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
>> # Date 1487697612 -3600
>> #      Tue Feb 21 18:20:12 2017 +0100
>> # Node ID 0deb181adc74dea75b109ebdf38fb73f5f20c724
>> # Parent  25fd71d9347a8c82adf2a991dab0b48ff35282f6
>> # EXP-Topic color
>> color: move triggering of the initialisation logic in core
>>
>> We now run the color initialisation as part of the standard dispatch. This is
>> opening the way for multiple cleanups since we now have access to the multiple 'ui'
>> object and we'll be able to see difference between global and local config. This
>> cleanup will arrive in later changesets.
>>
>> As a side effect, the '--color' flag is now working without the extension.
>>
>> Since we now properly initialize color for each ui idependently, we get a
>> warning message twice.
>
> Doubled warnings are a bit unfortunate, but that wouldn't be easily avoidable
> if we're going to handle per-ui differences correctly.

On way to fix it would be to check which group of 'key, value, source' 
have ben already warned about. However I would rather deal with this 
later as the main color code is complicated enough to migrated by itself.

Cheers,

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list