[PATCH 3 of 3 V2] summary: add evolution "troubles" information to parents header lines

[Pierre-Yves David]

On 01/05/2017 08:29 PM, Sean Farley wrote:
> Denis Laxalde <denis.laxalde at logilab.fr> writes:
>
>> Pierre-Yves David a écrit :
>>> On 11/08/2016 03:19 PM, Denis Laxalde wrote:
>>>> # HG changeset patch
>>>> # User Denis Laxalde <denis.laxalde at logilab.fr>
>>>> # Date 1475935828 -7200
>>>> #      Sat Oct 08 16:10:28 2016 +0200
>>>> # Node ID 35c0f05d694cb9541d60bad9a940cb93a39d615d
>>>> # Parent  b5d3d230bbc64d44968a9912e8e72aac8236522a
>>>> # EXP-Topic evolve-ui
>>>> summary: add evolution "troubles" information to parents header lines
>>>>
>>>> Extend labels of the `parent: ` line according to what `hg log`
>>>> displays when
>>>> coming from changeset_printer. This would make this line appear the
>>>> same in
>>>> log and summary with custom colors in particular.
>>>>
>>>> Extend that line with "troubles" information in parentheses, when the
>>>> parent
>>>> is troubled.
>>>
>>> I know there have been objection against that, but I cannot remember
>>> which one and why. Can you dig the mailing list a bit to see if you find
>>> something?
>>>
>>> Regarding the form, I would probably drop the "troubles:" part. eg:
>>>
>>>  parent: 15:73568ab6879d tip (unstable)
>>>
>>> Maybe we could use something else that (), but that seems fine so lets
>>> stay with this.
>>
>> Digging (a bit) the mailing list and only found this thread
>> https://www.mercurial-scm.org/pipermail/mercurial-devel/2015-December/076406.html
>> which does not specifically concerns the "troubles information in
>> parentheses" thing.
>>
>> That being said, if you think this is controversial, I'm very fine
>> giving up on extending the summary line.
>>
>> I still think it is worth having the labels consistent between log and
>> summary outputs.
>
> I would tend to agree with Denis here.

Yeah, I think that's enough digging. Thanks for doing it.

At that point I think we need a new batch with:

  - follow up on V4-P2 about the i18n tag
  - test follow up of V4-P2 with test of more than one trouble
  - V4-P4 with name fix (yuya), proper experimental marking (and 
potential split in two)
  - V4-P5 with updated test (to test a changeset with multiple troubles)

note: I realize I did not paid too much attention to the new label, I'll 
do a pass on that with the V5 batch (and we should add some them to the 
list of default label in color.

Cheers,

-- 
Pierre-Yves David