[PATCH] convert: add config option to control saving Git committer in message

[Sean Farley]

Gregory Szorc <gregory.szorc at gmail.com> writes:

> On Fri, Jan 6, 2017 at 11:48 AM, Sean Farley <sean at farley.io> wrote:
>
>> Gregory Szorc <gregory.szorc at gmail.com> writes:
>>
>> > On Fri, Jan 6, 2017 at 11:36 AM, Sean Farley <sean at farley.io> wrote:
>> >
>> >> Gregory Szorc <gregory.szorc at gmail.com> writes:
>> >>
>> >> > # HG changeset patch
>> >> > # User Gregory Szorc <gregory.szorc at gmail.com>
>> >> > # Date 1483729033 28800
>> >> > #      Fri Jan 06 10:57:13 2017 -0800
>> >> > # Node ID 1901566ab484a56b177b88ff080d635840e0912c
>> >> > # Parent  3de9df6ee5bf7601aa3870f18304bbeb3ce351af
>> >> > convert: add config option to control saving Git committer in message
>> >> >
>> >> > As part of converting a Git repository to Mercurial at Mozilla, I
>> >> > encountered a scenario where I didn't want `hg convert` to
>> >> > automatically add the "committer: <committer>" line to commit
>> messages.
>> >> > While I can hack around it downstream by rewriting the Git commit
>> >> > before feeding it into `hg convert`, I'd prefer to just specify a
>> >> > config flag to turn it off. This patch adds that flag.
>> >>
>> >> I'm fine with this as-is but what about maybe storing it in the
>> >> metadata? Just a thought.
>> >>
>> >
>> > I can implement that as a follow-up feature, behind yet another config
>> > flag. There's a reason I put "message" in the config option :)
>>
>> Fair enough :-)
>>
>
> Thinking about this a little more, I suppose I can have a single option
> defining a list of actions to take w.r.t. author and committer. If you feel
> this is more appropriate, please drop and I'll send V2.

At least to me, that sounds pretty robust / better.