[PATCH 2 of 2] summary: use ui.label and join to write evolution troubles
Denis Laxalde
denis at laxalde.org
Sat Jan 7 06:29:11 EST 2017
# HG changeset patch
# User Denis Laxalde <denis at laxalde.org>
# Date 1483788255 -3600
# Sat Jan 07 12:24:15 2017 +0100
# Node ID 246563462fd6b907b4ba215d200e0486ac10a535
# Parent e9057e86529463d4f4f0414bac8bf4dd2a290b0f
summary: use ui.label and join to write evolution troubles
Follow-up on 7b526670f540 to avoid a convoluted loop.
diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -5992,14 +5992,10 @@ def summary(ui, repo, **opts):
else:
ui.write(_(' (no revision checked out)'))
if p.troubled():
- ui.write(' (')
- troubles = p.troubles()
- for idx, trouble in enumerate(troubles, 1):
- ui.write(trouble,
- label='trouble.%s' % trouble)
- if idx < len(troubles):
- ui.write(', ')
- ui.write(')')
+ ui.write(' ('
+ + ', '.join(ui.label(trouble, 'trouble.%s' % trouble)
+ for trouble in p.troubles())
+ + ')')
ui.write('\n')
if p.description():
ui.status(' ' + p.description().splitlines()[0].strip() + '\n',
More information about the Mercurial-devel
mailing list