[PATCH 7 of 8] chg: remove getpager support

Jun Wu quark at fb.com
Tue Jan 10 22:40:39 EST 2017


Excerpts from Pierre-Yves David's message of 2017-01-10 18:22:39 +0100:
> 
> On 01/10/2017 03:45 PM, Yuya Nishihara wrote:
> > On Tue, 10 Jan 2017 07:12:27 +0800, Jun Wu wrote:
> >> # HG changeset patch
> >> # User Jun Wu <quark at fb.com>
> >> # Date 1484002779 -28800
> >> #      Tue Jan 10 06:59:39 2017 +0800
> >> # Node ID 24c7b11cecd12762d8238ec96c748131877054be
> >> # Parent  e44b1d6deadb67908b43909ad920572e3efa38e6
> >> # Available At https://bitbucket.org/quark-zju/hg-draft 
> >> #              hg pull https://bitbucket.org/quark-zju/hg-draft  -r 24c7b11cecd1
> >> chg: remove getpager support
> >>
> >> We have enough bits to switch to the new chg pager code path in runcommand.
> >> So just remove the legacy getpager support.
> >>
> >> This is a red-only patch, and will break chg's pager support temporarily.
> >
> > I love red patches. Queued the series, thanks!
> 
> Hooray for removing much code!
> I'm curious about the breakage however. It is not too important because 
> chg is experimental but is that breakage fixed by the next changeset? 
> could have reordered or folded this patch to avoid being temporarily broken?

If Patch 7 and Patch 8 were folded, there would be no breakage.

They are separated to comply with the small commit workflow.

> 
> Cheers,
> 


More information about the Mercurial-devel mailing list