[PATCH 3 of 3 V2] help: eliminate duplicate text for revset string patterns

Pierre-Yves David pierre-yves.david at ens-lyon.org
Fri Jan 13 03:04:01 EST 2017



On 01/13/2017 06:34 AM, Martin von Zweigbergk via Mercurial-devel wrote:
> On Thu, Jan 12, 2017 at 9:24 PM, Matt Harbison <mharbison72 at gmail.com> wrote:
>> # HG changeset patch
>> # User Matt Harbison <matt_harbison at yahoo.com>
>> # Date 1483850135 18000
>> #      Sat Jan 07 23:35:35 2017 -0500
>> # Node ID 2060486431053a99eafa4234aea139f6a31dc2d7
>> # Parent  29cbe16c5cccf600fae928df52dbd44171096a6f
>> help: eliminate duplicate text for revset string patterns
>>
>> There's no reason to duplicate this so many times, and it's likely an instance
>> will be missed if support for a new pattern is added and documented.  The
>> stringmatcher is mostly used by revsets, though it is also used for the 'tag'
>> related templates, and namespace filtering in the journal extension.  So maybe
>> there's a better place to document it.  `hg help patterns` seems inappropriate,
>> because that is all file pattern matching.
>>
>> While here, indicate how to perform case insensitive regex searches.

That series is pushed. Thanks.

>> diff --git a/mercurial/help/revsets.txt b/mercurial/help/revsets.txt
>> --- a/mercurial/help/revsets.txt
>> +++ b/mercurial/help/revsets.txt
>
> This file no longer exists. I merged it into revisions.txt very
> recently, so you should probably rebase this series on top of @ from
> the "committed" repo
> (https://www.mercurial-scm.org/repo/hg-committed/) and resend. Sorry.

I've renamed the file in the patch and it applied like a charmed. Thank 
for the pointer.

Cheers,

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list