[PATCH RFC] crecord: make an option for space key to move cursor down (issue5159) (RFC)
Pierre-Yves David
pierre-yves.david at ens-lyon.org
Fri Jan 13 07:29:05 EST 2017
On 01/12/2017 11:32 AM, Anton Shestakov wrote:
> On Tue, 10 Jan 2017 17:27:32 +0100
> Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
>
>> On 01/08/2017 03:19 AM, Anton Shestakov wrote:
>>> # HG changeset patch
>>> # User Anton Shestakov <av6 at dwimlabs.net>
>>> # Date 1483841309 -28800
>>> # Sun Jan 08 10:08:29 2017 +0800
>>> # Node ID 1afa1ffe6984bfe0027336ce0c83486e82ba2b50
>>> # Parent cfd14b0508ddf8edf156d202e2c5d07b259c2f46
>>> crecord: make an option for space key to move cursor down (issue5159) (RFC)
TL;DR; I move the option in [experimental] and pushed the patch so that
we can test the behavior.
It would be useful to have some test for this (I know crecord has some
tests)
We have various options here
0) change nothing
1) get a config option to change the behavior
2) use a modifier key
3) change the default behavior
4) find another better idea
In my opinion, option (0: change nothing) is off the table as their have
been enough people (including me) who express interests in having this
available in some way.
(1: config option) is not very appealing because it makes the behavior
hard to find and changes. I would rather have something easily
accessible from. However, an experimental option might be a good way to
test for (4: change behavior). In all case, I saw you introduced a new
[crecord] section. That seems like a bad idea for couple of reason
crecord is not a meaningful name and we try to not create too many new
config section for just one value. Having section gathered around on
theme help discovering other option when looking at the help.
(2: modifier key) the initial proposal "shift+space" can apparently
create issues with some input system and the combination itself did not
too convincing to Anton. So its currently a dead end.
(3: change behavior) might be a solution, its a curse UI and relatively
new, so I think we have some room to change things here. However I'm not
sure it is the right thing to do. Having an experimental config option
to turn that on seems a good way to play more with it a get an opinion.
Given the above, I've taken the current patch moving the option in
experimental. Please tests the option so that we can have an informed
discussion in the future.
(4: better solution?) Someone might have a breakthrough idea, here is a
small brainstorm:
maybe we could have a "selection" concept: you can selects line using
"shift+arrow" and then you can change the state of that whole section.
Maybe we could have a "break" key. That would "split" the current chunk
into two, so that one could select it independently.
Maybe we could have a "select this and everything below(or above?)" key?
Cheer,
--
Pierre-Yves David
More information about the Mercurial-devel
mailing list