[PATCH] check-code: reject module-level @cachefunc

[Sean Farley]

Martin von Zweigbergk via Mercurial-devel
<mercurial-devel at mercurial-scm.org> writes:

> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz at google.com>
> # Date 1484331097 28800
> #      Fri Jan 13 10:11:37 2017 -0800
> # Node ID 837c16d22b9fc6c2797978ade5b72688d79c862e
> # Parent  c390b40fe1d7d109f2b524356ce43013e570d294
> check-code: reject module-level @cachefunc
>
> Module-level @cachefunc usage is risky because it can easily create a
> memory "leak". Let's reject it completely for now. If a valid usage
> comes up in the future, we can always improve the check or reconsider.

Soundn fine to me. Looks good to me!