[PATCH] ui: rename tmpdir parameter to more specific repopath

Sean Farley sean at farley.io
Thu Jan 19 13:21:01 EST 2017


Yuya Nishihara <yuya at tcha.org> writes:

> On Wed, 18 Jan 2017 18:38:54 -0800, Sean Farley wrote:
>> # HG changeset patch
>> # User Sean Farley <sean at farley.io>
>> # Date 1484792751 28800
>> #      Wed Jan 18 18:25:51 2017 -0800
>> # Branch stable
>> # Node ID 41d220e2bed95664c335f6a7ef70b8ce06dca86c
>> # Parent  94af7d0c812fe7d3a5651191685ca43e1a331814
>> ui: rename tmpdir parameter to more specific repopath
>> 
>> This was requested by Augie and I agree that repopath is more
>> descriptive.
>> 
>> diff --git a/hgext/histedit.py b/hgext/histedit.py
>> index ae860d8..3e11fff 100644
>> --- a/hgext/histedit.py
>> +++ b/hgext/histedit.py
>> @@ -1333,11 +1333,11 @@ def ruleeditor(repo, ui, actions, editco
>>  
>>      rules = '\n'.join([act.torule() for act in actions])
>>      rules += '\n\n'
>>      rules += editcomment
>>      rules = ui.edit(rules, ui.username(), {'prefix': 'histedit'},
>> -                    tmpdir=repo.path)
>> +                    repopath=repo.path)
>
> repo.path could be set to ui at localrepository.__init__(), if we _always_
> want to switch the tempdir. Just an idea, which is obviously out of stable
> scope.

That's not a bad idea! I'll think about that after the freeze.


More information about the Mercurial-devel mailing list