[PATCH 4 of 5] ui: log time spent blocked on the user

Sean Farley sean at farley.io
Thu Jan 19 14:09:56 EST 2017


Simon Farnsworth <simonfar at fb.com> writes:

> # HG changeset patch
> # User Simon Farnsworth <simonfar at fb.com>
> # Date 1484842917 28800
> #      Thu Jan 19 08:21:57 2017 -0800
> # Node ID 93221dde2fad942c4f920dab1f346da71ac8033d
> # Parent  e8cd90ea5d3eee923304c64a19c3be9bce50451c
> ui: log time spent blocked on the user
>
> We use a wrapper around Mercurial at Facebook that logs key statistics (like
> elpased time) to our standard performance tooling.
>
> This is less useful than it could be, because we currently can't tell when a
> command is slow because we need to fix Mercurial versus when a command is
> slow because the user isn't interacting quickly.
>
> Teach Mercurial to log the time it spends blocked, so that our tooling can
> pick it up and submit it with the elapsed time - we can then do the math in
> our tooling to see if Mercurial is slow, or if the user simply failed to
> interact.

Augie cut a 4.1-rc yesterday so that means we're in a freeze until 4.1
is out. Though, this series looks good :-) Please resend after Feb. ~1.


More information about the Mercurial-devel mailing list