[PATCH stable] tests: also allow "Protocol not supported" in test-http-proxy error

Sean Farley sean at farley.io
Fri Jan 20 13:27:15 EST 2017


Augie Fackler <raf at durin42.com> writes:

> # HG changeset patch
> # User Augie Fackler <augie at google.com>
> # Date 1484925454 18000
> #      Fri Jan 20 10:17:34 2017 -0500
> # Branch stable
> # Node ID e82b540f38d6eb73c236a3ee313e263b414a61fa
> # Parent  763031a7690db0709bfbf21ad35123d9e03dcd11
> tests: also allow "Protocol not supported" in test-http-proxy error
>
> I've seen this in a (misconfigured) FreeBSD jail which has ::1 as an
> entry for localhost, but IPv6 support is disabled in the jail. It took
> me months to figure out what was going on (and I only figured it out
> when tinyproxy.py got confused by similar IPv4-level misconfiguration
> of the localhost domain in /etc/hosts.)
>
> I don't feel strongly about this patch: on the one hand, it's papering
> over a host-level misconfiguration, but on the other it avoids some
> weird and hard to diagnose problems that can occur in weirdly
> restricted environments.

I would say this is fine but that might just be me.


More information about the Mercurial-devel mailing list