[PATCH stable] tests: also allow "Protocol not supported" in test-http-proxy error

Martin von Zweigbergk martinvonz at google.com
Fri Jan 20 16:03:21 EST 2017


On Fri, Jan 20, 2017 at 12:52 PM, Augie Fackler <raf at durin42.com> wrote:
> On Fri, Jan 20, 2017 at 3:50 PM, Martin von Zweigbergk
> <martinvonz at google.com> wrote:
>>> diff --git a/tests/test-http-proxy.t b/tests/test-http-proxy.t
>>> --- a/tests/test-http-proxy.t
>>> +++ b/tests/test-http-proxy.t
>>> @@ -86,7 +86,7 @@ url with user name and password
>>>  bad host:port for proxy
>>
>> The "Protocol not supported" seems surprising, so how about adding a
>> brief explanation here? I can change it to the following in flight, or
>> something else if you have a better description.
>>
>>   bad host:port for proxy ("Protocol not supported" can happen on
>> misconfigured hosts)
>
>
> Your explanation is as good as anything I could contribute. Please
> feel encouraged to make that change in-flight.

Queued with that change made in flight (but line-wrapped), thanks.

>
> Thanks!
> Augie


More information about the Mercurial-devel mailing list