[PATCH 3 of 3 stable] tests: document probable bug in test-largefiles-update.t

Augie Fackler raf at durin42.com
Mon Jan 30 18:54:18 EST 2017


# HG changeset patch
# User Augie Fackler <augie at google.com>
# Date 1485817557 18000
#      Mon Jan 30 18:05:57 2017 -0500
# Branch stable
# Node ID e1db62cfe471bc278697d771bc68589acbff9171
# Parent  b4118549138f0872c218835d3ae10c9e70d867de
tests: document probable bug in test-largefiles-update.t

I don't really know what's going on here, so we should probably not
commit this patch, but my conclusion based on the analysis in earlier
patches is that the old use of --check was a defect. This also fails
2-3% of the time, as the code did before I moved the later call to
update to --clean.

diff --git a/tests/test-largefiles-update.t b/tests/test-largefiles-update.t
--- a/tests/test-largefiles-update.t
+++ b/tests/test-largefiles-update.t
@@ -705,6 +705,11 @@ the working context)
   $ hg status -A --rev '.^1' large2
   M large2
 
+Defect: this update *should* fail 100% of the time, because we already
+*know* the dirstate is dirty. Experimentally, at the time of this
+writing, the command only fails about 2% of the time.
+  $ hg update --check --quiet 4
+
 #else
 
 Test that "hg status" against revisions other than parent ignores exec


More information about the Mercurial-devel mailing list