[PATCH 2 of 2 v2] hgweb: forward arguments to ui.config

demelier.david at gmail.com demelier.david at gmail.com
Sat Jul 1 04:03:41 UTC 2017


On Thu, 2017-06-29 at 21:42 -0700, Jun Wu wrote:
> I might miss something, but why is this change necessary? I slightly
> prefer
> the old code where arguments are more explicit, and people can
> override
> untrusted to False.

The problem is that def.config uses a local _unset variable for the
default argument.

The hgweb_mod.py uses None so you get a warning while running the tests
because of this code:

 463             msg = ("specifying a default value for a registered "
 464                    "config item: '%s.%s' '%s'")

An other solution woudl be to rename _unset to unset and export it so
that hgweb_mod.py can pass unset instead of None by default.

What do you think?


More information about the Mercurial-devel mailing list