[PATCH 14 of 14] reposvfs: add a ward to check if locks are properly taken

Sean Farley sean at farley.io
Tue Jul 4 23:31:26 EDT 2017


Pierre-Yves David <pierre-yves.david at ens-lyon.org> writes:

> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
> # Date 1470672882 -7200
> #      Mon Aug 08 18:14:42 2016 +0200
> # Node ID a3c809a23ca3b90105e2156d30dc2700488598dd
> # Parent  4ef6ab01026fcb12b02f9224140e5e42cff56d61
> # EXP-Topic vfs.ward
> # Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
> #              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r a3c809a23ca3
> reposvfs: add a ward to check if locks are properly taken
>
> We use the 'ward' to check for the store lock when accessing file in '.hg/store'
> for writing. This caught a couple of instance where the transaction was released
> after the lock, we should probably have a dedicated checker for that case.

In general, I like this cleanup and new ward feature. Though, I'd like
if Yuya or others more familiar with vfs could take a second look. I've
marked it as pre-reviewed in patchwork.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170704/9d2a86b2/attachment.sig>


More information about the Mercurial-devel mailing list