[PATCH STABLE] revlog: add an experimental option to mitigated delta issues (issue5480)

[Sean Farley]

Kevin Bullock <kbullock+mercurial at ringworld.org> writes:

>> On Jul 4, 2017, at 22:07, Sean Farley <sean at farley.io> wrote:
>> 
>> Augie Fackler <raf at durin42.com> writes:
>> 
>>>> On Jul 3, 2017, at 4:53 PM, Gregory Szorc <gregory.szorc at gmail.com> wrote:
>>>> 
>>>>>> That's fair. I was on the fence about this anyways. Though, I did like
>>>>>> that _something_ would make these repos usable. I just noticed that the
>>>>>> commit has been marked public; don't know how strongly you feel about
>>>>>> this so up to you on how to proceed.
>>>>> 
>>>>> I agree this is unsuitable for stable. How do we want to proceed?
>>>>> 
>>>>> (I'll hold the 4.2.2 release until we get consensus here.)
>>>> 
>>>> I think we should back out from stable and re-land on default. The feature is appropriate for default, even with the noted pitfalls.
>>> 
>>> I’ve grafted the commit to default, pushed a backout to stable, and merged with i18n. I’ll probably roll the release sometime this afternoon.
>> 
>> Since this process was a bit opaque to me, perhaps we could do a few
>> things to clear it up for me (and hopefully others!) in the future:
>> 
>> - I think others need to actually weigh in for more of a consensus (I
>>  believe Martin and I agreed it was fine for stable)
>> 
>> - Now, that I think about it the only list of things appropriate for
>>  stable are here:
>> 
>>  https://www.mercurial-scm.org/wiki/TimeBasedReleasePlan?action=fullsearch&context=180&value=stable&titlesearch=Titles#Rules_for_code_freeze_and_stable_branch_commits
>> 
>> Can we get some clarification on things like this? I know I'd appreciate
>> it :-)
>
> Sorry for not weighing in on-list initially, but I agreed w/Augie's assessment. It's not explicitly covered by the guidelines you posted, but weighing the number of users impacted, the proximity to a new major release, and the fact that it adds a new flag, it belongs on default. That being said, we could certainly try to formalize the rules a bit better now that there's more than one person who makes the final call :)

(replying to both you and Augie)

Sure, makes sense. Perhaps at the next sprint we can hash out a list or
something.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170705/514a98cc/attachment.sig>