[PATCH 01 of 13 sparse] sparse: vendor Facebook-developed extension

Gregory Szorc gregory.szorc at gmail.com
Thu Jul 6 13:48:45 EDT 2017


On Wed, Jul 5, 2017 at 8:00 PM, Martin von Zweigbergk <martinvonz at google.com
> wrote:

>
>
> On Jul 5, 2017 7:34 PM, "Siddharth Agarwal" <sid at less-broken.com> wrote:
>
> On 7/5/17 3:35 PM, Augie Fackler wrote:
>
>> Yep. I think we'll need to bikeshed a bit around UX, but
>> experimental-in-core looks like it should offer some nice
>> consolidation and ease the path of getting narrow in core.
>>
>> I'm +1 on this too - Greg, do you want to address the bits of feedback
>> you got (about the choice of the merge module etc) and roll a v2?
>>
>
> While debugging something else I also found a bug in sparse -- matchers
> need to implement __repr__. If you can sneak a fix in that would be great,
> otherwise I can send a fix after this lands.
>
>
> Speaking of that, I had been looking forward to a patch to move the
> matcher into core and cleaning them up. I can do that once (v2+ of) this
> series lands.
>

Yeah, the matchers will definitely need some post-landing work. Sparse has
an optimization around "hashing" matchers. That bit in particular feels
like it will need love once things are in core.

I'll try to send a v2 today. Again, the focus is on landing bits first then
improving later.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170706/c4d060f0/attachment.html>


More information about the Mercurial-devel mailing list