[PATCH 06 of 11 sparse] sparse: move config updating function into core

Martin von Zweigbergk martinvonz at google.com
Mon Jul 10 18:16:49 EDT 2017


On Sat, Jul 8, 2017 at 4:29 PM, Gregory Szorc <gregory.szorc at gmail.com> wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc at gmail.com>
> # Date 1499548773 25200
> #      Sat Jul 08 14:19:33 2017 -0700
> # Node ID bafbabb23d7c584a0744e0bf6426d72649f14453
> # Parent  bdba7b6ce456921675ebf2dd54efd567709ed446
> sparse: move config updating function into core
>
> As part of the move, the code has changed slightly:
>
> * Now using a context manager for wlock
> * We always call parseconfig() because parsing an empty string
>   will yield empty data structures
> * The variable for the old sparse matcher was renamed
> * The try..except block was shortened to only cover refreshdir().
>   This is what importfromfiles() does and I think it is more
>   appropriate.

I'm sorry, but do you mind splitting the move and the refactoring up
for this patch too? This one changed a little too much for it to be
easy to spot the differences by quickly switching back and forth.

I'm queuing patch 4 and 5, thanks.


More information about the Mercurial-devel mailing list