[PATCH 4 of 4] [RFC] color: support different styling depending on color support (BC)

[Kyle Lippincott]

On Sun, Jul 9, 2017 at 9:32 PM, Jun Wu <quark at fb.com> wrote:

> I think the series is a good improvement and can be queued with some small
> in-flight fixes.
>
> Excerpts from Gregory Szorc's message of 2017-07-09 16:46:17 -0700:
> > diff --git a/mercurial/color.py b/mercurial/color.py
> > --- a/mercurial/color.py
> > +++ b/mercurial/color.py
> > @@ -135,13 +135,31 @@ except ImportError:
> >      'diff.inserted': 'green',
> >      'diff.tab': '',
> >      'diff.trailingwhitespace': 'bold red_background',
> > -    'changeset.public' : '',
> > -    'changeset.draft' : '',
> > -    'changeset.secret' : '',
> > +    'changeset.public': {
> > +        8: '',
> > +        16: 'brightred',
>
> This is mostly nitpicking, but red seems to be mostly about errors or
> warnings. I'd vote "brightgreen" for public changesets. Or make public
> brightyellow and draft non-bright yellow.
>
> > [...]
>
> Not only in colortable, it seems config support is also worthwhile, like:
>
>   [color]
>   changeset.public:8 = ...
>   changeset.public:16 = ...
>
> That could be a future patch.
>

I would definitely use this in config if it was available :)


> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170710/fbff1dbb/attachment.html>