[PATCH] template: rename successorssets template into successorgroup

[Yuya Nishihara]

On Mon, 10 Jul 2017 12:45:12 -0700, Sean Farley wrote:
> Yuya Nishihara <yuya at tcha.org> writes:
> > On Fri, 07 Jul 2017 21:07:18 +0200, Boris Feld wrote:
> >> # HG changeset patch
> >> # User Boris Feld <boris.feld at octobus.net>
> >> # Date 1499454363 -7200
> >> #      Fri Jul 07 21:06:03 2017 +0200
> >> # Node ID 508801f7cd1304488b0d9ebf02a76be030608b21
> >> # Parent  e714159860fd0872ae0555bb07546aa7e9f700e0
> >> # EXP-Topic renamesuccessosrssetstemplate
> >> template: rename successorssets template into successorgroup
> >> 
> >> The new name seems better and easier to remember for users.
> >> 
> >> diff -r e714159860fd -r 508801f7cd13 mercurial/templatekw.py
> >> --- a/mercurial/templatekw.py	Fri Jul 07 08:33:10 2017 +0200
> >> +++ b/mercurial/templatekw.py	Fri Jul 07 21:06:03 2017 +0200
> >> @@ -602,8 +602,8 @@
> >>                     lambda x: {'ctx': repo[x], 'revcache': {}},
> >>                     lambda d: _formatrevnode(d['ctx']))
> >>  
> >> - at templatekeyword("successorssets")
> >> -def showsuccessorssets(repo, ctx, **args):
> >> + at templatekeyword("successorgroup")
> >> +def showsuccessorgroup(repo, ctx, **args):
> >>      """Returns a string of sets of successors for a changectx
> >
> > Can we rename it to "successorgroups" (plural) as it's the convention of
> > templatekw? The inner list should be renamed to "successorgroup" or "group"
> > as well.
> 
> Should I do this before pushing (forgot to push!)?

I prefer waiting V2 since this is just a single-line patch renaming the
function.