[Differential] [Request, 2 lines] D49: modcheck: whitelist lz4revlog

Jun Wu quark at fb.com
Tue Jul 11 17:09:00 EDT 2017


Sorry for this. I misconfigured the phabricator.callsign config.

Excerpts from quark (Jun Wu)'s message of 2017-07-11 21:07:29 +0000:
> quark created this revision.
> Herald added a subscriber: mercurial-devel.
> 
> REVISION SUMMARY
>   Sometimes `test-check-*` were skipped. Upon investigation, it's because
>   `lz4revlog` was imported and `hg` printed warnings with `modcheck`. So let's
>   make `lz4revlog` whitelisted.
> 
> REPOSITORY
>   rHG Mercurial
> 
> REVISION DETAIL
>   https://phab.mercurial-scm.org/D49 
> 
> AFFECTED FILES
>   tests/modcheck.py
> 
> CHANGE DETAILS
> 
> Index: tests/modcheck.py
> ===================================================================
> --- tests/modcheck.py
> +++ tests/modcheck.py
> @@ -17,7 +17,7 @@
>  dirname = os.path.dirname
>  
>  # skip checking external modules
> -skipmodre = re.compile(r'\Amysql|remotenames|hgsubversion.*\Z')
> +skipmodre = re.compile(r'\Amysql|remotenames|hgsubversion.*|lz4revlog\Z')
>  
>  reporoot = dirname(dirname(__file__))
>  pyroot = dirname(os.__file__)
> 
> 
> EMAIL PREFERENCES
>   https://phab.mercurial-scm.org/settings/panel/emailpreferences/ 
> 
> To: quark
> Cc: mercurial-devel, indygreg


More information about the Mercurial-devel mailing list