[PATCH 4 of 4] [RFC] color: support different styling depending on color support (BC)

Sean Farley sean at farley.io
Tue Jul 11 19:14:32 EDT 2017


Kyle Lippincott <spectral at pewpew.net> writes:

> On Sun, Jul 9, 2017 at 9:32 PM, Jun Wu <quark at fb.com> wrote:
>
>> I think the series is a good improvement and can be queued with some small
>> in-flight fixes.
>>
>> Excerpts from Gregory Szorc's message of 2017-07-09 16:46:17 -0700:
>> > diff --git a/mercurial/color.py b/mercurial/color.py
>> > --- a/mercurial/color.py
>> > +++ b/mercurial/color.py
>> > @@ -135,13 +135,31 @@ except ImportError:
>> >      'diff.inserted': 'green',
>> >      'diff.tab': '',
>> >      'diff.trailingwhitespace': 'bold red_background',
>> > -    'changeset.public' : '',
>> > -    'changeset.draft' : '',
>> > -    'changeset.secret' : '',
>> > +    'changeset.public': {
>> > +        8: '',
>> > +        16: 'brightred',
>>
>> This is mostly nitpicking, but red seems to be mostly about errors or
>> warnings. I'd vote "brightgreen" for public changesets. Or make public
>> brightyellow and draft non-bright yellow.

For what it's worth, I've defined the following throughout the years:

public -> blue
draft -> green
secret -> red

I've used yellow for "labeling" (no inherent meaning; just things like
user / date / subject). I might follow-up with some nice templates /
mapfiles if people want those.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170711/e1ccb441/attachment.sig>


More information about the Mercurial-devel mailing list