[PATCH] amend: new extension providing the amend command

Jun Wu quark at fb.com
Wed Jul 12 03:40:50 EDT 2017


Excerpts from Martin von Zweigbergk's message of 2017-07-11 23:18:21 -0700:
> I use "hg amend -e" quite often. Would be nice to have that too.
>
> Comparing this to evolve's version, there are a few differences:
> 
> * Missing support for --edit and --logfile (as noted above, I
> personally often use the former). Looks like this patch still allows
> --logfile, but will perhaps result in a 'options --message and
> --logfile are mutually exclusive' message?

Good point. I missed "-l".

> * Missing support for evolve's experimental --current-{date,user}
> options. Not sure if we care

That sounds like "-d now" or "-u SOMETHING".

> * Added locking, which seems like a good idea to do before
> repo['.'].description(). In fact, that probably fixes
> https://bz.mercurial-scm.org/show_bug.cgi?id=5266 

Nice mention of the bug. I did consider the race but wasn't aware we had a
bug already.

> * Calls into _docommit() instead of commit(), which makes sense given
> the item above (commit() just takes the locks and then calls
> _docommit())

V2 will address the "-l" and "-e" issue, plus a bit simplification in the
test.


More information about the Mercurial-devel mailing list