[Differential] [Updated] D57: match: write forceincludematcher using unionmatcher
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Wed Jul 12 13:49:50 EDT 2017
martinvonz added a comment.
In https://phab.mercurial-scm.org/D57#743, @durham wrote:
> makeittso <https://phab.mercurial-scm.org/file/data/seqiyiucw2e7mbqo2yva/PHID-FILE-puljaopc7cgeb5dg43j5/makeittso.jpeg>
>
> Might be nice to have unit tests for matchers, now that they're getting some complications.
I think the most interesting part to test would be visitdir(), because that's not tested much by our test suite ("def visitdir(self, dir): return True" would pass almost all tests). So it seems to me like https://phab.mercurial-scm.org/D58 would benefit more from unit tests. patternmatcher and includematcher are more complex and would benefit more from unit tests.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D57
EMAIL PREFERENCES
https://phab.mercurial-scm.org/settings/panel/emailpreferences/
To: martinvonz
Cc: durham, dsp, mercurial-devel
More information about the Mercurial-devel
mailing list